Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E smoke test #1962

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Add E2E smoke test #1962

merged 1 commit into from
Feb 4, 2025

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Feb 3, 2025 •
edited
Loading

creates a smoke test for the zabbix data source

closes https://github.com/grafana/data-sources/issues/194

@gwdawson gwdawson requested a review from adamyeats February 3, 2025 16:06
@gwdawson gwdawson requested a review from a team as a code owner February 3, 2025 16:06
adamyeats
adamyeats approved these changes Feb 3, 2025
View reviewed changes
Copy link

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🚀

@gwdawson gwdawson merged commit 525217d into main Feb 4, 2025
14 checks passed
@gwdawson gwdawson deleted the gareth/add-smoke-test branch February 4, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamyeats adamyeats adamyeats approved these changes

@ivanahuckova ivanahuckova ivanahuckova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OSS Big Tent
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwdawson @adamyeats @ivanahuckova