Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix AlertList styling #1894

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Bug: Fix AlertList styling #1894

merged 1 commit into from
Oct 15, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Oct 15, 2024

  • as part of Chore: Migrate more SCSS grafana#90224, i removed these SCSS styles from core grafana
    • unfortunately the dashboard i was using to see which plugins were using which styles never flagged this plugin as using them 😭
    • still need to dig into how and why these usages weren't shown
  • copy these styles into the plugin where they can be controlled and adjusted at your leisure 😄

thanks to @PedroRibas13 @mplm17 for raising this 🙇

Fixes #1868

@ashharrison90 ashharrison90 self-assigned this Oct 15, 2024
@ashharrison90 ashharrison90 requested a review from a team as a code owner October 15, 2024 10:02
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this for us @ashharrison90 🫶

@zoltanbedi zoltanbedi merged commit 4fb774d into main Oct 15, 2024
4 checks passed
@zoltanbedi zoltanbedi deleted the ash/fix-missing-styles branch October 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts Panel got really bad after Grafana update
2 participants