Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item.get cache won't be hit if tags order are different #1745

Merged
merged 2 commits into from
Dec 4, 2023
Merged

item.get cache won't be hit if tags order are different #1745

merged 2 commits into from
Dec 4, 2023

Conversation

iqbalaydrus
Copy link
Contributor

Solves #1744

@iqbalaydrus iqbalaydrus requested a review from a team as a code owner November 15, 2023 08:03
@iqbalaydrus iqbalaydrus requested review from gabor and yesoreyeram and removed request for a team November 15, 2023 08:03
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zoltanbedi
Copy link
Member

Hey @iqbalaydrus,
thank you for your pr we are going to take a look at it in the meantime can you please try to add tests for this?

@iqbalaydrus
Copy link
Contributor Author

Ok, I added unit test for this PR

zoltanbedi
zoltanbedi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

@zoltanbedi zoltanbedi merged commit dfe360b into grafana:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@gabor gabor Awaiting requested review from gabor gabor is a code owner automatically assigned from grafana/oss-big-tent

@yesoreyeram yesoreyeram Awaiting requested review from yesoreyeram yesoreyeram is a code owner automatically assigned from grafana/oss-big-tent

Assignees
No one assigned
Labels
None yet
Projects
OSS Big Tent
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iqbalaydrus @CLAassistant @zoltanbedi