Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting ForceAuthn SAML request attribute #357

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

MohammedAlmeshal
Copy link
Contributor

Hello @mostafa,

This PR adds support for optionally configuring the ForceAuthn attribute in SAML requests. The attribute is defaulted to False and can be configured through the setting field FORCE_AUTHN, which will be mapped to pysaml2's force_authn configuration directive.

I haven't found an appropriate way to test it; would appreciate your guidance if needed.

@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Almeshal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution! 🙏

I'm not sure about testing either. 🤷‍♂️ Have you tested this with your IdP for acceptance?

@MohammedAlmeshal
Copy link
Contributor Author

Yes, I tested it against my IdP with all the values, and it is working as expected.
My pleasure, thank you for making my first OS contribution so enjoyable ❤️

@mostafa mostafa merged commit 801bdb2 into grafana:main Dec 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants