Improve tool UI and support nested thoughts #10226
Conversation
* group thoughts when nested
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/56fcac2cfca44b2f9f556cd676aaa1f4358162c9/gradio-5.9.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@56fcac2cfca44b2f9f556cd676aaa1f4358162c9#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/56fcac2cfca44b2f9f556cd676aaa1f4358162c9/gradio-client-1.8.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/56fcac2cfca44b2f9f556cd676aaa1f4358162c9/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
| @@ -35,6 +35,8 @@ | |||
|
|
|||
| class MetadataDict(TypedDict): | |||
| title: Union[str, None] | |||
| id: NotRequired[int] | |||
| parent_id: NotRequired[int] | |||
There was a problem hiding this comment.
this is just so i could test in a demo, i'll remove this later
There was a problem hiding this comment.
Why remove this, we'll need to keep it so that developers can control which thoughts are nested inside which other ones, right?
There was a problem hiding this comment.
yeah true, didnt know if this should be done outside of this pr though!
There was a problem hiding this comment.
let's do it as part of this pr I think so we can test things end-to-end
| @@ -206,7 +207,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| {#if layout === "bubble"} | |||
| {#if layout === "bubble" && should_show_buttons} | |||
There was a problem hiding this comment.
shouldn't show buttons for thoughts
| /* Colors */ | ||
| .bubble .bot { | ||
| border-color: var(--border-color-primary); | ||
| } |
There was a problem hiding this comment.
wasnt used/needed
| @@ -0,0 +1,186 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
renamed MessageBox.svelte to Thought.svelte
|
Design looks great! As mentioned internally, I think it would be better if we are able to find a way to display tools without removing the border around chat messages |
|
What do you think about automatically getting and displaying the time it took for the thought to complete as part of the thought heading? |
Description
Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.
Closes: #(issue)
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh