Fix: make sure source link is configured and open in external browser #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
requested review from
thedadams,
ryanhopperlowe,
g-linville and
tylerslaton
|
@StrongMonkey Does this open up the file when clicked? |
|
yes, it will open up the file in external browser @tylerslaton |
tylerslaton
reviewed
Sep 11, 2024
| win.webContents.on('will-navigate', (event, url) => { | ||
| if (url.startsWith('file://')) { | ||
| event.preventDefault(); | ||
| shell.openExternal(url); |
There was a problem hiding this comment.
Any reason to not just use the default of the system like the other button? Is it because this catches all navigation events?
There was a problem hiding this comment.
I tested and the one above doesn't work but this works. I got this from chatgpt.
tylerslaton
approved these changes
Sep 11, 2024
thedadams
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280
The default url transform in our markdown library seems to be stripping out url with file://. This break our knowledge response when giving source link reference that points to files.