fix: address issues with how parameters work for subtools #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
StrongMonkey,
thedadams,
njhale and
ryanhopperlowe
and removed request for
StrongMonkey and
thedadams
tylerslaton
force-pushed
the
issue-413
branch
from
9d713cb to
9015c1a
Compare
tylerslaton
changed the title
thedadams
reviewed
Sep 9, 2024
thedadams
requested changes
Sep 9, 2024
Signed-off-by: tylerslaton <[email protected]>
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
issue-413
branch
from
9015c1a to
a716a22
Compare
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
issue-413
branch
from
a716a22 to
dd43c6e
Compare
|
@thedadams I added what I mentioned earlier. Can you take a look and see if you like it better? |
thedadams
approved these changes
Sep 10, 2024
ryanhopperlowe
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things relating to how setting parameters for sub tools work. It removed the "plus" button as well as the "enter" keybinding for new params. Instead, there is a new button to add params. This improves the UX since many users were getting confused why their params were not automatically persisting.
There was another confusing issue where tools without chat would have the chat bar enabled. This has been addressed and looks like the following.
There is a third issue here where the running of this tool does not actually requests the user to input their parameters. This will be fixed in a follow-up to minimize the size of this PR. That change will take some work.
#413