fix: improve multiple prompts #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a prompt was followed by another prompt, React was "helping" us by not completing resetting the state. This caused an issue where the old state would be used in the next prompt, making it appear as though the prompt was already submitted. This change will reset this state so it will not be reused. This change also includes some small changes around what is displayed before and after prompts. For example, when an authentication prompt disappeared, the message would still say, "<Tool> needs to authenticate ." Now, the message will switch back to "Waiting for model response..." Signed-off-by: Donnie Adams <[email protected]>
|
fixes it for me 🙌 |
thedadams
requested review from
cjellick,
njhale,
StrongMonkey,
ryanhopperlowe and
tylerslaton
cjellick
previously approved these changes
Sep 7, 2024
Signed-off-by: Donnie Adams <[email protected]>
|
I realized later that we could clean up some of the state, so I did that. |
ryanhopperlowe
approved these changes
Sep 9, 2024
g-linville
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a prompt was followed by another prompt, React was "helping" us by not completing resetting the state. This caused an issue where the old state would be used in the next prompt, making it appear as though the prompt was already submitted.
This change will reset this state so it will not be reused.
This change also includes some small changes around what is displayed before and after prompts. For example, when an authentication prompt disappeared, the message would still say,
" needs to authenticate ." Now, the message will switch back to "Waiting for model response..."