enhance: Improve display for tool names when adding/removing tools fr… #454
Conversation
ryanhopperlowe
requested review from
njhale,
StrongMonkey,
thedadams,
g-linville and
tylerslaton
and removed request for
njhale,
StrongMonkey and
thedadams
|
Looks like conflicts need to be resolved here. |
ryanhopperlowe
force-pushed
the
290-names-of-the-tools-are-incorrect-when-adding-tools-using-add-tool-option-in-chat-threads
branch
from
df1ec20 to
cb79621
Compare
There was a problem hiding this comment.
Looking good. One piece of feedback on the UX:
When I add a tool, the name of the tool now looks like it is a hyperlink (see the screenshot). However, when I click on the name, nothing happens.
My suggestion is to either make it such that it doesn't look like a hyperlink or make the hyperlink work.
ryanhopperlowe
force-pushed
the
290-names-of-the-tools-are-incorrect-when-adding-tools-using-add-tool-option-in-chat-threads
branch
from
cb79621 to
793a7e0
Compare
What if we went with a dotted underline instead? 
|
|
@ryanhopperlowe In my opinion, something being a hyperlink is indicated by the fact that my mouse pointer changes when I hover over it. I think the dotted-underline is nice, but I think it would also need to not change the cursor. |
hooks/useClickOutside.tsx
Outdated
| ) { | ||
| console.log('fire click outside'); |
There was a problem hiding this comment.
nit: debug log should be removed
ryanhopperlowe
force-pushed
the
290-names-of-the-tools-are-incorrect-when-adding-tools-using-add-tool-option-in-chat-threads
branch
from
f00cb84 to
13a5014
Compare
ryanhopperlowe
deleted the
290-names-of-the-tools-are-incorrect-when-adding-tools-using-add-tool-option-in-chat-threads
branch
…om a chat
Now when adding or removing a tool from a chat. It will fetch the display name of the tool and display it with a tooltip containing the url. If no display name is found, it displays the url with no tooltip instead
#290