fix: imported tool names and icons on edit page #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
cjellick,
thedadams,
StrongMonkey,
iwilltry42 and
g-linville
njhale
force-pushed
the
fix/edit-tool-import-names
branch
2 times, most recently
from
b2361ae to
cf6ad21
Compare
StrongMonkey
approved these changes
Aug 23, 2024
Fix the imported tools section of the edit page by: - Loading remote tools to get the correct display names - Using the full remote tool refs to select icons This ensures tools get display names and icons that match the ones used in the tool catalog. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/edit-tool-import-names
branch
from
cf6ad21 to
3d4ba2a
Compare
cjellick
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the imported tools section of the edit page by:
This ensures tools get display names and icons that match the ones
used in the tool catalog.