fix: erase script content when switching threads #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Aug 15, 2024
Comment on lines
+3
to
+9
| "version": "v0.10.0-rc3", | ||
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": { | ||
| "": { | ||
| "name": "acorn", | ||
| "version": "v0.10.0-rc2", | ||
| "version": "v0.10.0-rc3", |
There was a problem hiding this comment.
Not sure why these weren't already updated, since I didn't make any changes to package.json. 🤷♂️
There was a problem hiding this comment.
Yeah we should enforce that at ci level, like doing a npm install and check if git is dirty
g-linville
requested review from
thedadams,
njhale,
StrongMonkey and
iwilltry42
thedadams
approved these changes
Aug 15, 2024
StrongMonkey
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #161
The issue linked above was happening whenever the user switches from a Claude thread back to a normal gpt-4o. I figured out that this is just one case of a broader bug in the code, where switching threads can cause the previously selected script to execute.
The script context has a
scriptandscriptContentstate, the latter taking priority over the former. The thread code was overwritingscriptbut doing nothing toscriptContent, which was the source of the issue here.