Feat: Add eslint and prettier config. Add pr check for lint #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
approved these changes
Aug 14, 2024
g-linville
reviewed
Aug 14, 2024
.dockerignore
Outdated
There was a problem hiding this comment.
Hmm prettier seems to be doing format this file too. I can add it to ignore
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
setup-linter
branch
from
135ce03 to
96de8ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up eslint and prettier config to enforce lint rules. It uses some of the common rule pattern from js world which I am not super familiar with.