Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in AbstractExcelImporter.evaluateAllFormulaCells() #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jnunderwood
Copy link

  1. AbstractExcelImporter.evaluateAllFormulaCells() references Cell.CELL_TYPE_FORMULA. Instead, it should reference CellType.FORMULA. I suspect this worked at one time, but Apache-POI has since been updated.
  2. I have also added an optional argument to evaluateAllFormulaCells(boolean inCell = false) that will call evaluateInCell(c) if true. Otherwise, it will call evaluateFormulaCell(c). This fixes a problem I was encountering with formulas not being evaluated. I wrote this so that the default behavior has not changed, however, so it should not break any existing code.

Copy link
Member

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants