fix bug in AbstractExcelImporter.evaluateAllFormulaCells() #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractExcelImporter.evaluateAllFormulaCells()
referencesCell.CELL_TYPE_FORMULA
. Instead, it should referenceCellType.FORMULA
. I suspect this worked at one time, but Apache-POI has since been updated.evaluateAllFormulaCells(boolean inCell = false)
that will callevaluateInCell(c)
if true. Otherwise, it will callevaluateFormulaCell(c)
. This fixes a problem I was encountering with formulas not being evaluated. I wrote this so that the default behavior has not changed, however, so it should not break any existing code.