PYIC-2410 Test to enforce curly quotes #1821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe-Edwards-GDS
force-pushed
the
pyic-2410-ensure-curly-quotes
branch
from
013496b to
33e768e
Compare
|
DanCorderIPV
requested changes
Jan 31, 2025
|
@DanCorderIPV I expect this will clash with your GOV.UK frontend update which is probably more important :) - happy for you to either manage the merges yourself, or leave this until I return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Write a unit test to check that we don't include any straight quotes in our translations, and use appropriate apostrophe/quote characters.
Why did it change
The straight quotes are typographically incorrect (even if easier to type).
Issue tracking