PYIC-7933: Update content on F2F handoff (booking confirmation) page #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanshuit914
force-pushed
the
PYIC-7933
branch
3 times, most recently
from
9ae8eb0 to
369477e
Compare
shivanshuit914
force-pushed
the
PYIC-7933
branch
5 times, most recently
from
9985348 to
9f49073
Compare
MikeCollingwood
previously approved these changes
Jan 24, 2025
blakeyp
reviewed
Jan 24, 2025
src/app/ipv/middleware.ts
Outdated
| @@ -357,6 +357,10 @@ export const handleJourneyPageRequest = async ( | |||
| } else if (pageId === PAGES.PYI_TRIAGE_MOBILE_DOWNLOAD_APP) { | |||
| validatePhoneType(context); | |||
| renderOptions.appDownloadUrl = getAppStoreRedirectUrl(context); | |||
| } else if (pageId === PAGES.PAGE_FACE_TO_FACE_HANDOFF) { | |||
| renderOptions.postOfficeVisitByDate = new Date().setDate( | |||
| new Date().getDate() + 15, | |||
There was a problem hiding this comment.
We probably want to pull 15 out into config - it doesn't need to be an env var but we could define it in config.ts perhaps?
blakeyp
reviewed
Jan 24, 2025
src/app/development/middleware.ts
Outdated
Comment on lines
116
to
128
| let today = new Date(); | ||
| if (process.env.NODE_ENV === "local") { | ||
| today = new Date("2025-01-01"); | ||
| } | ||
| renderOptions.postOfficeVisitByDate = new Date().setDate( | ||
| today.getDate() + 15, | ||
| ); |
There was a problem hiding this comment.
could we have this just always hardcode the date (rather than relying on NODE_ENV being set to local) ?
should be fine for just a preview of the page
shivanshuit914
force-pushed
the
PYIC-7933
branch
2 times, most recently
from
faefa34 to
7b520bb
Compare
blakeyp
reviewed
Jan 24, 2025
shivanshuit914
force-pushed
the
PYIC-7933
branch
2 times, most recently
from
667c6a6 to
0d4bb1b
Compare
shivanshuit914
force-pushed
the
PYIC-7933
branch
from
0d4bb1b to
57d04ed
Compare
shivanshuit914
force-pushed
the
PYIC-7933
branch
from
57d04ed to
daff62d
Compare
|
blakeyp
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Issue tracking