PYIC-7910 Preload templates for all pages #1779
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe-Edwards-GDS
force-pushed
the
pyic-7910-preload-templates
branch
from
1e38de1 to
e491fee
Compare
|
|
This doesn't appear to have had the desired effect, so parking this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Pre-render all pages on startup, to ensure they are cached before serving requests
Why did it change
We see a high rate of 503s when spinning up new containers during a load test, suggesting that new containers are seeing a high event loop latency.
One possible explanation is that this is occurring when loading uncached templates from disk (as Nunjucks does this synchronously). By preloading the templates, we should be able to keep the event loop latency low once serving requests.
Issue tracking