Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-1424: Support filtering keys by use in JwkCache #5887

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

cearl1
Copy link
Contributor

@cearl1 cearl1 commented Feb 7, 2025

Wider context of change

Previously, we added a JwkCache that would cache JWKs from a URL. This class did not differentiate between key uses though, so could retrieve a signing key to be used in encryption for example.

What’s changed

A keyUse field has been added to JwkCacheEntry. When keys are retrieved from the JWKS URL, they are filtered to only include keys that match the use field. Additionally, JwkCache has been renamed to EncryptionJwkCache to be more specific.

Checklist

  • Impact on orch and auth mutual dependencies has been checked.
  • Changes have been made to contract tests or not required.
  • Changes have been made to the simulator or not required.
  • Changes have been made to stubs or not required.
  • Successfully deployed to authdev or not required.
  • Successfully run Authentication acceptance tests against sandpit or not required.

@cearl1 cearl1 requested review from a team as code owners February 7, 2025 14:56
@cearl1 cearl1 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 8ef117d Feb 7, 2025
12 checks passed
@cearl1 cearl1 deleted the ATO-1424/filter-jwks-by-type-in-jwkcache branch February 7, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants