Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATO-1322: Swap getter in AccountInterventionsHandler #5886

Draft
wants to merge 2 commits into
base: ATO-1284-update-base-frontend-handler
Choose a base branch
from
Draft

ATO-1322: Swap getter in AccountInterventionsHandler #5886

wants to merge 2 commits into from
+21 −16

Conversation

Ryan-Andrews99
Copy link
Contributor

@Ryan-Andrews99 Ryan-Andrews99 commented Feb 7, 2025 •
edited
Loading

What:

  • Uses the auth session getter for getInternalCommonSubjectId to get the value instead of the shared session one
  • Also updated a common test variable name

How to review

  • Code review commit

Checklist

  • Impact on orch and auth mutual dependencies has been checked.
  • No changes required or changes have been made to stub-orchestration.
  • A UCD review has been performed.

Related PRs:

@Ryan-Andrews99 Ryan-Andrews99 changed the base branch from main to ATO-1284-update-base-frontend-handler February 7, 2025 14:39
@Ryan-Andrews99 Ryan-Andrews99 changed the title Ato 1322 account interventions handler ATO-1322: account interventions handler Feb 7, 2025
@Ryan-Andrews99 Ryan-Andrews99 force-pushed the ATO-1284-update-base-frontend-handler branch from e695619 to 90a3362 Compare February 10, 2025 09:36
@Ryan-Andrews99
BAU: Rename common test var
ff62e03 
Renames test var to be INTERNAL_COMMON_SUBJECT_ID instead of
just COMMON_SUBJECT_ID
@Ryan-Andrews99
ATO-1322: Replace getter in account interventions
5d7fd63 
Also makes use of the renamed common test variable to make this
clearer
@Ryan-Andrews99 Ryan-Andrews99 force-pushed the ATO-1322-accountInterventions-handler branch from b0a3c3d to 5d7fd63 Compare February 10, 2025 10:46
@Ryan-Andrews99 Ryan-Andrews99 changed the title ATO-1322: account interventions handler ATO-1322: Swap getter in AccountInterventionsHandler Feb 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ryan-Andrews99