ATO-1169: check if docAppSubjectId is defined in logs #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only place any setter on Auths ClientSession Class is called. Orch already sets it in AuthorisationHandler, so we should be able to safely remove this. If this assumoption is correct, then we can safely just pass the client session from orch to auth, and orch can forget about it. Ie, we don't need any info from Auth to set on the ClientSession.
GHSwallow
force-pushed
the
ATO-1169/check-if-setter-is-necessary
branch
from
8103af0 to
6090364
Compare
|
isaac-GDS
approved these changes
Feb 7, 2025
Ryan-Andrews99
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wider context of change
This is part of the work to scope out the ClientSession table migration. See epic here: https://govukverify.atlassian.net/browse/ATO-1106
What’s changed
Adds logging to check if docAppSubjectId is defined. This is the only place any setter on Auths ClientSession Class is called. Orch already sets it in AuthorisationHandler, so we should be able to safely remove this. If this assumoption is correct, then we can safely just pass the client session from orch to auth, and orch can forget about it. Ie, we don't need any info from Auth to set on the ClientSession.