ATO-1239: add running of provider test in contract test workflow #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java Tests Not SkippedJava files were previously skipped in this pull request. Subsequent changes have caused the tests to be run. |
isaac-GDS
force-pushed
the
ATO-1239/upload-provider-to-pact-broker
branch
19 times, most recently
from
3591ace to
709786a
Compare
isaac-GDS
force-pushed
the
ATO-1239/upload-provider-to-pact-broker
branch
from
709786a to
3d937f4
Compare
cearl1
reviewed
Feb 7, 2025
| environment "AWS_ACCESS_KEY_ID", "mock-access-key" | ||
| environment "AWS_REGION", "eu-west-2" | ||
| environment "DYNAMO_ENDPOINT", "http://localhost:8000" | ||
| environment "REDIS_KEY", "session" | ||
| environment "TRACING_ENABLED", "false" | ||
| environment "AWS_SECRET_ACCESS_KEY", "mock-secret-key " |
There was a problem hiding this comment.
Should there be a trailing space on the key here? Looks a bit odd
There was a problem hiding this comment.
It does look weird. Not sure if its needed but i copied it from the environments in the integration tests above.
There was a problem hiding this comment.
Ah fair enough, I guess it was ignoring whitespace then. As long as it works! 😄
|
cearl1
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify pact test from the prod pact broker. If you have access you can see under
clientRegistryProviderUpdated the gradle build with needed env variables
Updated workflow to verify pacts
Added comments to provider test to be able to run locally.
No further testing needed.