AUT-4030: ias: Dedup and tidy variables

govuk-one-login · Feb 11, 2025 · 0ee6a99 · 0ee6a99
1 parent 9ed9c4b
commit 0ee6a99
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 10 deletions.
diff --git a/ci/terraform/interventions-api-stub/authdev1.tfvars b/ci/terraform/interventions-api-stub/authdev1.tfvars
@@ -1,3 +1,2 @@
-environment         = "authdev1"
 shared_state_bucket = "di-auth-development-tfstate"
 vpc_environment     = "dev"
diff --git a/ci/terraform/interventions-api-stub/authdev2.tfvars b/ci/terraform/interventions-api-stub/authdev2.tfvars
@@ -1,3 +1,2 @@
-environment         = "authdev2"
 shared_state_bucket = "di-auth-development-tfstate"
 vpc_environment     = "dev"
diff --git a/ci/terraform/interventions-api-stub/build.tfvars b/ci/terraform/interventions-api-stub/build.tfvars
@@ -1,6 +1,11 @@
 interventions_api_stub_release_zip_file = "./artifacts/interventions-api-stub.zip"
 shared_state_bucket                     = "digital-identity-dev-tfstate"
-logging_endpoint_arns = [
-  "arn:aws:logs:eu-west-2:885513274347:destination:csls_cw_logs_destination_prodpython"
-]
+
+# VPC
 orchestration_vpc_endpoint_id = "vpce-0867442e4d95fb43e"
+
+# Logging
+logging_endpoint_arns = ["arn:aws:logs:eu-west-2:885513274347:destination:csls_cw_logs_destination_prodpython"]
+
+# Scaling
+lambda_min_concurrency = 1
diff --git a/ci/terraform/interventions-api-stub/dev.tfvars b/ci/terraform/interventions-api-stub/dev.tfvars
@@ -1,3 +1,5 @@
 interventions_api_stub_release_zip_file = "./artifacts/interventions-api-stub.zip"
 shared_state_bucket                     = "di-auth-development-tfstate"
-orchestration_vpc_endpoint_id           = "vpce-0028f62dad635589a"
+
+# VPC
+orchestration_vpc_endpoint_id = "vpce-0028f62dad635589a"
diff --git a/ci/terraform/interventions-api-stub/sandpit.tfvars b/ci/terraform/interventions-api-stub/sandpit.tfvars
@@ -1,3 +1,4 @@
-environment                   = "sandpit"
-shared_state_bucket           = "digital-identity-dev-tfstate"
+shared_state_bucket = "digital-identity-dev-tfstate"
+
+# VPC
 orchestration_vpc_endpoint_id = "vpce-0028f62dad635589a"
diff --git a/ci/terraform/interventions-api-stub/variables.tf b/ci/terraform/interventions-api-stub/variables.tf
@@ -42,12 +42,12 @@ variable "lambda_max_concurrency" {
 }
 
 variable "scaling_trigger" {
-  default = 0.7
+  default = 0.6
   type    = number
 }
 
 variable "lambda_min_concurrency" {
-  default     = 1
+  default     = 0
   type        = number
   description = "The number of lambda instance to keep 'warm'"
 }