feat: Use of configurable concurrency for extracting assets from BigQuery #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayurjag
force-pushed
the
configurable-concurrency-bq
branch
from
857fd81 to
e85cb55
Compare
haveiss
reviewed
Jan 18, 2024
Mayurjag
force-pushed
the
configurable-concurrency-bq
branch
4 times, most recently
from
47117d6 to
1b78dd6
Compare
haveiss
reviewed
Jan 19, 2024
batrov
reviewed
Jan 19, 2024
Mayurjag
force-pushed
the
configurable-concurrency-bq
branch
5 times, most recently
from
9df98b8 to
2d5b09e
Compare
batrov
reviewed
Jan 19, 2024
Mayurjag
force-pushed
the
configurable-concurrency-bq
branch
2 times, most recently
from
4196f02 to
0852aec
Compare
haveiss
reviewed
Jan 19, 2024
| @@ -219,17 +220,27 @@ func (e *Extractor) Extract(ctx context.Context, emit plugins.Emit) error { | |||
| return err | |||
| } | |||
|
|
|||
| ch := make(chan *bigquery.Dataset, len(datasets)) | |||
There was a problem hiding this comment.
just parallel all the dataset, and use the buffered channel to process the concurrency of the tables
Mayurjag
force-pushed
the
configurable-concurrency-bq
branch
from
0852aec to
c245de6
Compare
haveiss
force-pushed
the
configurable-concurrency-bq
branch
from
49ae7da to
dccb304
Compare
haveiss
approved these changes
Jan 19, 2024
haveiss
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.