Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): do not send preview field and rows if max_preview_rows is -1 #46

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat(bigquery): do not send preview field and rows if max_preview_rows is -1 #46

merged 5 commits into from
Nov 28, 2023

Conversation

utsav14nov
Copy link

@utsav14nov utsav14nov commented Nov 27, 2023 •
edited by bsushmith
Loading

closes #43

@utsav14nov utsav14nov self-assigned this Nov 27, 2023
@utsav14nov utsav14nov linked an issue Nov 27, 2023 that may be closed by this pull request
Restrict sending PreviewRows fields in table asset from meteor to compass #43
Closed
@anjali9791 anjali9791 self-requested a review November 28, 2023 09:36
@bsushmith bsushmith changed the title feat: adds maxPreviewRows -1 logic to not send previewRows and Fields feat(bigquery): do not send preview field and rows if max_preview_rows is -1 Nov 28, 2023
@bsushmith bsushmith requested a review from haveiss November 28, 2023 09:51
@utsav14nov utsav14nov merged commit a147080 into main Nov 28, 2023
28 of 53 checks passed
@bsushmith bsushmith deleted the issue_43 branch November 29, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjali9791 anjali9791 anjali9791 approved these changes

@bsushmith bsushmith bsushmith approved these changes

@haveiss haveiss Awaiting requested review from haveiss

Assignees

@utsav14nov utsav14nov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict sending PreviewRows fields in table asset from meteor to compass
3 participants
@utsav14nov @bsushmith @anjali9791