Skip to content

Commit

Permalink
Fix spelling of resolveable -> resolvable (#284)
Browse files Browse the repository at this point in the history
* Fix spelling of resolveable -> resolvable (make it backwards compatible for now)

* Update expected generated tests with "resolvable"

* Update rest of tests, now that I've confirmed it is backward compatible
  • Loading branch information
aelsabbahy authored Sep 12, 2017
1 parent ff8dc52 commit 2506b94
Show file tree
Hide file tree
Showing 12 changed files with 115 additions and 110 deletions.
14 changes: 7 additions & 7 deletions docs/manual.md
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ $ curl localhost:8080/healthz
```bash
$ goss validate --format documentation
File: /etc/hosts: exists: matches expectation: [true]
DNS: localhost: resolveable: matches expectation: [true]
DNS: localhost: resolvable: matches expectation: [true]
[...]
Total Duration: 0.002s
Count: 10, Failed: 2, Skipped: 0
Expand Down Expand Up @@ -439,13 +439,13 @@ command:


### dns
Validates that the provided address is resolveable and the addrs it resolves to.
Validates that the provided address is resolvable and the addrs it resolves to.

```yaml
dns:
localhost:
# required attributes
resolveable: true
resolvable: true
# optional attributes
server: 8.8.8.8
addrs:
Expand All @@ -472,21 +472,21 @@ To validate specific DNS address types, prepend the hostname with the type and a
dns:
# Validate a CNAME record
CNAME:dnstest.github.io:
resolveable: true
resolvable: true
server: 8.8.8.8
addrs:
- "github.map.fastly.net."
# Validate a PTR record
PTR:8.8.8.8:
resolveable: true
resolvable: true
server: 8.8.8.8
addrs:
- "google-public-dns-a.google.com."
# Validate and SRV record
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
server: 8.8.8.8
addrs:
- "0 5 443 a.dnstest.io."
Expand All @@ -498,7 +498,7 @@ Please note that if you want `localhost` to **only** resolve `127.0.0.1` you'll
```yaml
dns:
localhost:
resolveable: true
resolvable: true
addrs:
consist-of: [127.0.0.1]
timeout: 500 # in milliseconds
Expand Down
18 changes: 9 additions & 9 deletions integration-tests/goss/alpine3/goss-expected-q.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,39 +56,39 @@ command:
timeout: 10000
dns:
CAA:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
CNAME:c.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
MX:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
NS:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
PTR:8.8.8.8:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
TXT:txt._test.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
ip6.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
localhost:
resolveable: true
resolvable: true
timeout: 1000
process:
apache2:
Expand Down
18 changes: 9 additions & 9 deletions integration-tests/goss/alpine3/goss-expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,60 +70,60 @@ command:
timeout: 10000
dns:
CAA:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 issue comodoca.com
- 0 issue letsencrypt.org
- 0 issuewild ;
timeout: 1000
server: 8.8.8.8
CNAME:c.dnstest.io:
resolveable: true
resolvable: true
addrs:
- a.dnstest.io.
timeout: 1000
server: 8.8.8.8
MX:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 10 b.dnstest.io.
- 5 a.dnstest.io.
timeout: 1000
server: 8.8.8.8
NS:dnstest.io:
resolveable: true
resolvable: true
addrs:
- ns1.dnstest.io.
- ns2.dnstest.io.
timeout: 1000
server: 8.8.8.8
PTR:8.8.8.8:
resolveable: true
resolvable: true
addrs:
- google-public-dns-a.google.com.
timeout: 1000
server: 8.8.8.8
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 5 443 a.dnstest.io.
- 10 10 443 b.dnstest.io.
timeout: 1000
server: 8.8.8.8
TXT:txt._test.dnstest.io:
resolveable: true
resolvable: true
addrs:
- Hello DNS
timeout: 1000
server: 8.8.8.8
ip6.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 2404:6800:4001:807::200e
timeout: 1000
server: 8.8.8.8
localhost:
resolveable: true
resolvable: true
addrs:
- 127.0.0.1
- ::1
Expand Down
18 changes: 9 additions & 9 deletions integration-tests/goss/centos7/goss-expected-q.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,39 +56,39 @@ command:
timeout: 10000
dns:
CAA:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
CNAME:c.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
MX:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
NS:dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
PTR:8.8.8.8:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
TXT:txt._test.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
ip6.dnstest.io:
resolveable: true
resolvable: true
timeout: 1000
server: 8.8.8.8
localhost:
resolveable: true
resolvable: true
timeout: 1000
process:
foobar:
Expand Down
18 changes: 9 additions & 9 deletions integration-tests/goss/centos7/goss-expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,60 +76,60 @@ command:
timeout: 10000
dns:
CAA:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 issue comodoca.com
- 0 issue letsencrypt.org
- 0 issuewild ;
timeout: 1000
server: 8.8.8.8
CNAME:c.dnstest.io:
resolveable: true
resolvable: true
addrs:
- a.dnstest.io.
timeout: 1000
server: 8.8.8.8
MX:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 10 b.dnstest.io.
- 5 a.dnstest.io.
timeout: 1000
server: 8.8.8.8
NS:dnstest.io:
resolveable: true
resolvable: true
addrs:
- ns1.dnstest.io.
- ns2.dnstest.io.
timeout: 1000
server: 8.8.8.8
PTR:8.8.8.8:
resolveable: true
resolvable: true
addrs:
- google-public-dns-a.google.com.
timeout: 1000
server: 8.8.8.8
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 5 443 a.dnstest.io.
- 10 10 443 b.dnstest.io.
timeout: 1000
server: 8.8.8.8
TXT:txt._test.dnstest.io:
resolveable: true
resolvable: true
addrs:
- Hello DNS
timeout: 1000
server: 8.8.8.8
ip6.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 2404:6800:4001:807::200e
timeout: 1000
server: 8.8.8.8
localhost:
resolveable: true
resolvable: true
addrs:
- 127.0.0.1
- ::1
Expand Down
22 changes: 11 additions & 11 deletions integration-tests/goss/goss-shared.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,72 +63,72 @@ group:
exists: false
dns:
CAA:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 issue comodoca.com
- 0 issue letsencrypt.org
- 0 issuewild ;
timeout: 2000
server: 8.8.8.8
CNAME:c.dnstest.io:
resolveable: true
resolvable: true
addrs:
- a.dnstest.io.
timeout: 2000
server: 8.8.8.8
c.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 192.30.252.153
timeout: 2000
server: 8.8.8.8
MX:dnstest.io:
resolveable: true
resolvable: true
addrs:
- 10 b.dnstest.io.
- 5 a.dnstest.io.
timeout: 2000
server: 8.8.8.8
NS:dnstest.io:
resolveable: true
resolvable: true
addrs:
- ns1.dnstest.io.
- ns2.dnstest.io.
timeout: 2000
server: 8.8.8.8
PTR:8.8.8.8:
resolveable: true
resolvable: true
addrs:
- google-public-dns-a.google.com.
timeout: 2000
server: 8.8.8.8
SRV:_https._tcp.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 0 5 443 a.dnstest.io.
- 10 10 443 b.dnstest.io.
timeout: 2000
server: 8.8.8.8
TXT:txt._test.dnstest.io:
resolveable: true
resolvable: true
addrs:
- Hello DNS
timeout: 2000
server: 8.8.8.8
ip6.dnstest.io:
resolveable: true
resolvable: true
addrs:
- 2404:6800:4001:807::200e
timeout: 2000
server: 8.8.8.8
localhost:
resolveable: true
resolvable: true
addrs:
- 127.0.0.1
- "::1"
timeout: 2000
dnstest.io:
resolveable: true
resolvable: true
server: 8.8.8.8
timeout: 2000
process:
Expand Down
Loading

0 comments on commit 2506b94

Please sign in to comment.