Ensure list view uses FH results #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we don't have to run unnecessary requests
stefpiatek
commented
Nov 21, 2022
jhughes982
approved these changes
Dec 5, 2022
Comment on lines
+168
to
+178
| beforeAll(() => { | ||
| /* | ||
| * For some reason on first load of FHIR server, creating a batch of requests doesn't seem to validate | ||
| * Sending a resource before any test are run fixed the issue | ||
| */ | ||
| const practitioner = new Practitioner(); | ||
| practitioner.resourceType = "Practitioner"; | ||
| practitioner.identifier = [createIdentifier("initial")]; | ||
| return createPractitioner(practitioner); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Interesting, is this a frontend issue I wonder? Does it work if you interact with the backend directly? Hopefully this doesn't cause any user interaction issues on the deployed application.
There was a problem hiding this comment.
yeah it's only the first time a FHIR server is spun up that it happens which is interesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now implementing the results list for FH patients and using the new structure of the FHIR bundle 🎉
closes #63