Test result list #92
Test result list #92
Conversation
stefpiatek
force-pushed
the
test-results
branch
from
392721a to
71d3f53
Compare
stefpiatek
force-pushed
the
test-results
branch
from
71d3f53 to
0358365
Compare
| const renderTestReportForm = () => { | ||
| render(<ContextAndModal children={<ReportForm initialValues={noValues} />} />, { wrapper: BrowserRouter }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Is this needed in order to render a modal during the test?
One thing to consider. It could be beneficial to weigh up having more integration tests vs. having a small number of end-to-end tests that go through the form like a human would. You could use a tool called Puppeteer or Cypress to do this.
There was a problem hiding this comment.
Yep it is! though also a router is also required so that we can use useNavigate, even if we're mocking it. Agreed, though this style of integration testing also feels similar to how a user would interact with the site, that would give us the benefit of not having to create our component for testing
| beforeEach(() => { | ||
| return clearFhirAndSendReports(); | ||
| }); |
There was a problem hiding this comment.
Does this test delete the data already in the development fhir server if its run locally? I'm just thinking whether it's desirable for a test to change the data? I guess it doesn't matter too much, but thought I'd raise the question.
There was a problem hiding this comment.
Yeah it does, I think that if this were rolled out further into production then it might be worth adding some guards to the setup functions so that they can't be run on a real server.
Adding in automated tests for result list, also ensured use of identifiers that should have been there before
Closes #89