-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundle and processing #83
Conversation
Allows for querying for an identifier by a specific system which is fun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few comments to address.
Also:
At some point I did manage to produce an error when submitting the form, and the console complained of an uncaught error inside this function: const bundle = bundleRequest(values, reportedHened)
. However, I'm not sure exactly what triggered this error and I wasn't able to reproduce it afterwards. It might have just been a quirk during development (e.g. the dev server refreshed and it messed up the data). But I thought I'd mention it here. Wrapping the function in a try catch
might be worth it perhaps?
# Conflicts: # package.json # src/components/reports/ReportForm.tsx # src/fhir/api.ts
No rush on reviewing, but sending off while I remember. Can wait until you start back on this project, a week on monday
Parts left to do:
closes #33
closes #53