Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing to allow for modal test #82

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

stefpiatek
Copy link
Collaborator

  • went for slimming down the dev FHIR server to only minimal required, as we're not using this in production
  • found the source of why tests were flaky! - turns out by default tests are ran in parallel, might be worth looking in the jest documentation to see if there's a way to mark individual tests as having to be run sequentially, otherwise using the command line flag that I've set for npm test should work
  • Updated some of the test setup so that the modal should then be able to work during testing. Might be worth experimenting to see if we need to have any timeout at all now that we're not running tests in parallel

@stefpiatek stefpiatek requested a review from acholyn October 18, 2022 09:57
@acholyn acholyn merged commit 042032a into feature/parse-bundle-and-add-errors-to-modal Oct 18, 2022
@stefpiatek stefpiatek deleted the reportform_test branch November 14, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants