Results table modal

[jhughes982]

• Added modal to display check for cascade testing,
• Also added fallback modals in case there are no patients to iterate through,
• Feedback welcome on the use of guard clauses to prevent undefined data... Is there a better way of doing this?
• closes Add modal or notification if patient has a positive finding and there is only one patient with that family number #62

[stefpiatek]

🎉 thanks for doing this - not sure if my comment on guard clauses is that astounding but does save a small bit I hope

[stefpiatek]

We could make this a bit more clear by ? and also using !(with && and && linking). so maybe something like this?

Suggested change

	if (
	!patient.id ||
	!patient.identifier ||
	!patient.identifier[0].value ||
	!patient.name ||
	!patient.name[0].given ||
	!patient.name[0].family
	) {
	if (!(
	patient.id &&
	patient.identifier?.get(0)?.value &&
	patient.name?.get(0)?.given &&
	patient.name?.get(0)?.family
	)) {

[stefpiatek]

I don't think this line is necessary in the guard as it's covered below

[jhughes982]

Thanks for the suggestions. I think that is now a bit leaner and more semantically correct. Needs a bit of concentration to follow through the logic though unfortunately.