Results list route #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefpiatek
approved these changes
Oct 12, 2022
src/pages/Results.tsx
Outdated
| const [parsedResults, setParsedResults] = useState<parsedResultsModel | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| const observationQueryUrl = `${FHIR_URL}/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; |
There was a problem hiding this comment.
I think the fhir context is instantiated with the base URL, so can just use this and remove the reuse of the env variable
Suggested change
| const observationQueryUrl = `${FHIR_URL}/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; | |
| const observationQueryUrl = `/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; |
stefpiatek
reviewed
Oct 13, 2022
…assed successfully
stefpiatek
approved these changes
Oct 13, 2022
Comment on lines
13
to
20
| type trimmedObservation = { cDnaChange: string | undefined; observationId: string | undefined }; | ||
| type patientResult = { | ||
| firstName: string | undefined; | ||
| lastName: string | undefined; | ||
| patientId: string | undefined; | ||
| observations: trimmedObservation[]; | ||
| }; | ||
| export type parsedResultsModel = patientResult[]; |
There was a problem hiding this comment.
I think the convention for types is to have a capital first letter, or am I getting my languages mixed up?
| const [parsedResults, setParsedResults] = useState<parsedResultsModel | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| const observationQueryUrl = `${FHIR_URL}/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; |
There was a problem hiding this comment.
We don't need the FHIR URL in this, and can remove the import
Suggested change
| const observationQueryUrl = `${FHIR_URL}/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; | |
| const observationQueryUrl = `/Observation?_profile=http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/variant&_include=Observation:subject`; |
| return subjectIdLong.includes(patientId); | ||
| }); | ||
|
|
||
| if (!patientObservations || patientObservations.length === 0) return; |
There was a problem hiding this comment.
personal preference but I'd aim to make logic branches obvious
Suggested change
| if (!patientObservations || patientObservations.length === 0) return; | |
| if (!patientObservations || patientObservations.length === 0) { | |
| return; | |
| } |
| }; | ||
|
|
||
| if (!parsedResults) { | ||
| return <div>Getting observations.</div>; |
There was a problem hiding this comment.
is this getting observations at that point? - I would have thought that's covered in loading spinner but maybe I'm getting confused
| if (!observation || !observation.component) return; | ||
|
|
||
| const trimmedObservation = observation.component.filter((component) => { | ||
| const loincCode = "48004-6"; |
There was a problem hiding this comment.
might be worth having this as a constant at the top level of the file and name it as something like HGVS_CDNA_LOINC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anytype in these cases. Is there a better way to add accurate typings here?app.tsxto expose the necessary methods toResults.tsx. As a result, I have removed a few imports inNewReport.tsx.