Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/parse bundle and add errors to modal #77

Merged
merged 66 commits into from
Nov 9, 2022
Merged

Feature/parse bundle and add errors to modal #77

merged 66 commits into from
Nov 9, 2022

Conversation

acholyn
Copy link
Collaborator

@acholyn acholyn commented Oct 12, 2022 •
edited
Loading

closes #74

@acholyn
Merge branch 'feature/parse-bundle-and-add-errors-to-modal' of github…
738a06a 
….com:gosh-dre/gmsa_genomic_fhir_webapp into feature/parse-bundle-and-add-errors-to-modal

consolidating merge updates
@acholyn
Copy link
Collaborator Author

acholyn commented Oct 12, 2022 •
edited
Loading

Things for feedback:
in api.ts:

  • I'd have preferred to use .filter() but it doesn't like !2 as an arg but can figure out another way if the current doesn't suit
  • line 162 ;not sure why it's warning me about issue maybe being undefined
  • I've (hopefully) made it into an array for a table, did you want it done another way?

is testUtilities in the right place? (fhir) and are the contents fine?

@stefpiatek stefpiatek self-requested a review October 13, 2022 13:59
stefpiatek
stefpiatek reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, missed this for a while. I live by being added to reviews by github so it emails me for reviews but you didn't know that!

stefpiatek
stefpiatek reviewed Oct 14, 2022
View reviewed changes
@acholyn
adding verbose to test script
b00d074
@acholyn
small tweaks to tests
ccb811e 
error modal should pass, redirect after submission may say conflict
@acholyn acholyn temporarily deployed to test-env November 7, 2022 17:26 Inactive
@acholyn acholyn temporarily deployed to test-env November 8, 2022 10:56 Inactive
@acholyn acholyn requested a review from stefpiatek November 8, 2022 11:00
@acholyn acholyn temporarily deployed to test-env November 8, 2022 11:31 Inactive
stefpiatek
stefpiatek approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to see this working, some outstanding comments from last time still need to be addressed, but basically all stylistic

src/components/reports/ReportForm.test.tsx
Comment on lines +169 to +171
await waitFor(() => {
expect(screen.getByText(/error/i, { selector: "h2" })).toBeInTheDocument();
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this, worth checking to see if tests pass without it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can go back to the previous way of doing it, that works

@acholyn acholyn temporarily deployed to test-env November 9, 2022 10:52 Inactive
@acholyn acholyn temporarily deployed to test-env November 9, 2022 12:11 Inactive
@acholyn acholyn temporarily deployed to test-env November 9, 2022 12:32 Inactive
@acholyn acholyn merged commit 132decd into main Nov 9, 2022
@acholyn acholyn deleted the feature/parse-bundle-and-add-errors-to-modal branch November 9, 2022 12:58
@acholyn acholyn restored the feature/parse-bundle-and-add-errors-to-modal branch November 9, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse bundle response and add errors to error modal
2 participants
@acholyn @stefpiatek