Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundle idenfitiers #75

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Fix bundle idenfitiers #75

merged 2 commits into from
Oct 12, 2022

Conversation

stefpiatek
Copy link
Collaborator

Fixes two issues with not using identifiers within the bundle

  • alter the service request and plan references to use an identifier query parameter
  • use identifier in the resource bundle for practitioners so we won't get duplicate reporting/authorising scientists!

Otherwise defined a custom FHIR type that we know will always have its fields filled in so we don't have to pretent that they could be undefined

@stefpiatek stefpiatek temporarily deployed to test-env October 10, 2022 16:13 Inactive
@stefpiatek stefpiatek merged commit c2e6f31 into main Oct 12, 2022
@stefpiatek stefpiatek deleted the fix_bundle_idenfitiers branch October 12, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acholyn acholyn acholyn approved these changes

@jhughes982 jhughes982 Awaiting requested review from jhughes982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefpiatek @acholyn