Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example bundle #73

Closed
wants to merge 4 commits into from
Closed

Update example bundle #73

wants to merge 4 commits into from

Conversation

stefpiatek
Copy link
Collaborator

@stefpiatek stefpiatek commented Oct 10, 2022

Updating bundle based on Eze's example

Copy link
Collaborator Author

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new bundle @EthelEz 👏 .
I've have had a look through the bundle - would you be able to go through my comments. Might be easiest to schedule a meeting to go through these after you've had a while to look at them

@stefpiatek stefpiatek requested a review from EthelEz October 10, 2022 11:32
Copy link
Collaborator Author

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outcome of discussion

Comment on lines +419 to +428
{
"code": {
"coding": [
{
"system": "http://loinc.org",
"code": "81297-4",
"display": "CNV"
}
]
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variant in this observation is a SNV, not a CNV so will need to remove. @EthelEz to ask Natassa for example reports with CNVs in to then model the data. I'm happy to help also help with the modelling while we're working on the project

@stefpiatek stefpiatek changed the base branch from reordered_bundle to main October 25, 2022 13:45
@stefpiatek
Copy link
Collaborator Author

Temporarily closing, will reopen when have implemented changes

@stefpiatek stefpiatek closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants