Github deployment in actions #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Won't deploy if there are no changes
jhughes982
approved these changes
Oct 5, 2022
Comment on lines
-32
to
+28
| - run: npm run deploy | ||
| - run: npm run predeploy |
There was a problem hiding this comment.
So we want to run predeploy directly here without the full npm run deploy operation?
There was a problem hiding this comment.
Yeah because the deploy creates a local commit so we'd need to setup a github user within the action which is a massive pain. Instead we build it and then let the specific github action for deployment handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some fun with this, it appears the jekyll out the jekyll deployment is required for the environmental variables to be read within the react app. Also made a change to the modal message because a deployment will be skipped if there aren't any changes