Fhir api tests #65
Merged
Fhir api tests #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eugh that is very silly of me
Don't mock fetch in api tests
…atient was created
pass/fail rate is iffy, might be down to refresh rate though that should've been fixed
stefpiatek
reviewed
Oct 4, 2022
There was a problem hiding this comment.
🎉 Looking good!
Thanks for working on this.
One thing that would be good is to see that if we're updating information as well, could you add another test that processed the initialValues, then updates the date of birth of the patient in the initial values and then processes them. Then we check that the final date of birth is the updated value
stefpiatek
reviewed
Oct 4, 2022
…r_webapp into fhir-api-tests
stefpiatek
approved these changes
Oct 10, 2022
streamlining errors definition Co-authored-by: Stefan Piatek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.