Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Commit

Permalink
AMO validation errors: do not rely on innerHTML
Browse files Browse the repository at this point in the history
  • Loading branch information
@gorhill
gorhill committed Oct 5, 2017
1 parent acf318d commit 893b885
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions src/cloud-ui.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title></title>
</head>
<body>
<button id="cloudPush" type="button" title="cloudPush"></button>
<span data-i18n="cloudNoData"></span>
<button id="cloudPull" type="button" title="cloudPull" disabled></button>
<button id="cloudPullAndMerge" type="button" title="cloudPullAndMerge" disabled></button>
<p id="cloudError"><span></span></p>
<span id="cloudCog" class="fa">&#xf013;</span>
<div id="cloudOptions">
<div>
<p><label data-i18n="cloudDeviceNamePrompt"></label> <input id="cloudDeviceName" type="text" value="">
<p><button id="cloudOptionsSubmit" type="button" data-i18n="genericSubmit"></button>
</div>
</div>
</body>
</html>

1 comment on commit 893b885

@leedoyle
Copy link

@leedoyle leedoyle commented on 893b885 Nov 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gorhill Hello! I couldn't find a bug tracker, so I thought I should probably leave it here.
Bug #1: when visiting twitter.com with default uMatrix settings (with twimg.com blocked, it being a third party domain), browser hotkeys, e.g. Ctrl+F and Ctrl+D don't work. Allowing the twimg.com domain solves the issue. I reproduced the bug on Firefox 55-56 on Linux (uMatrix 1.0.0) and Chromium 61 on Linux . uMatrix Version 1.0.0 (the latest in Chrome Store)

Bug #2: Keyboard Shortcuts don't work in Chromium on Linux (the latest uMatrix 1.0.0 from Chrome Store). The only key shortcut working is "activate the extension", others, like Open dashboard, Revert all temporary changes .Temporarily whitelist all, Temporarily whitelist page domain don't work at all.
That's really frustrating because it would streamline user experience a lot if these hotkeys actually worked.

Sorry for any possible inconvenience this may have caused and thanks for your work!
Best regards

Please sign in to comment.