Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AA] Making dev branch compile and passing paperLabelName parameter #35

Open
wants to merge 66 commits into
base: dev
Choose a base branch
from

Conversation

arcadius
Copy link

@arcadius arcadius commented Jun 24, 2018

  • Had to comment some of the iOS code to make the project compile on iOS
  • Added a new param paperLabelName ( that can be for instance W62 or or W62RB or ..... Note that I have tested only W62RB)
  • These changes work for both Android and iOS

While we are awaiting approval and merge from @gordobot , you can install the fixed version by doing:

cordova plugin add https://github.com/MenelicSoftware/cordova-plugin-brother-label-printer#dev --save

@gordol
Copy link
Owner

gordol commented Jun 24, 2018

Cool! If someone else can verify that this works, I'm happy to merge it now. Otherwise, I'm in the middle of moving, and won't be able to test this for at least a week or two. Apologies... Thanks so much for your hard work on this!

@gordol
Copy link
Owner

gordol commented Jun 24, 2018

What are the binary changes here? Updated android libraries?

@arcadius arcadius changed the title [AA] passing paperLabelName parameter to indicate label in printer. This i… [AA] Making dev branch compile and passing paperLabelName parameter Jun 24, 2018
@arcadius
Copy link
Author

@Ayiga and @VictorCoding ... would you be able to verify that this install and works for both android and ios when the paperLabelName is passed in?

@arcadius
Copy link
Author

arcadius commented Jun 24, 2018

What are the binary changes here? Updated android libraries?

Good catch @gordol :-)

The binary library upgrade was unintentional and has been reverted.
The focus of this pull request is to get the iOS in dev working and have the label name passed down to the printer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants