Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating plugin interface with updates to support Brother API updates. #29

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

eugenedw
Copy link

@eugenedw eugenedw commented Mar 21, 2018

This pull request includes changes to make the plugin more compatible with the latest Brother API.

Key updates include:

  1. Removing deprecated methods as defined in the documentation for the API
  2. Added a procedure for specifying the label size (this can be enhanced by having the plugin provide a means for the user to supply the required label size and printer)

@eugenedw
Copy link
Author

Please exclude the second commit - 0801a0a

@gordol
Copy link
Owner

gordol commented Mar 22, 2018

Cool, thanks! I'm out of town until next week, but I can probably take a look at this tomorrow. Hang tight, thanks for the effort!

@gordol
Copy link
Owner

gordol commented Mar 22, 2018

Is there really no check label in printer method anymore?

@gordol
Copy link
Owner

gordol commented Mar 22, 2018

We shouldn't hard code it if possible...

@gordol
Copy link
Owner

gordol commented Mar 23, 2018

hey if you can, make a new branch for this pull request, that way you can do stuff on your master in your fork w/o it affecting your pull request.

@eugenedw
Copy link
Author

Sorry about that. Just saw your comments. I should've made those changes in a branch, there've been several since that first pull request. How should I clean this up to make it easier for you? In this latest version I added the ability to parameterize the paper selection. This was a problem when trying to print to some QL models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants