feat: Add StepPlayer module docs #1328
Conversation
neverbiasu
changed the title
| emit('stepCompleted') | ||
| } | ||
|
|
||
| function handleUserAction(clickedElement: HTMLElement) { |
There was a problem hiding this comment.
你可能没搞清楚我们要求跟着模块接口文档一起提交伪代码的目的；它主要是为了确保你们验证了你们设计的接口能帮助使用方去实现需求
你在 StepPlayer 接口文档 PR 里提交 StepPlayer 的实现伪代码其实是不合理的，因为后者跟 StepPlayer 的接口关系不大，反而是跟别的 StepPlayer 所依赖的模块（比如 Tagging）的接口设计关系比较大；跟着 StepPlayer 接口文档提交的应该是 NodeTaskPlayer 中使用 StepPlayer 的伪代码
不过考虑到 #1326 中已经包含了 NodeTaskPlayer 中使用 StepPlayer 的伪代码，你这里先把这个 feature_StepPlayer.md 删掉吧，StepPlayer 的接口比较简单，我就直接 merge 了；至于对 Tagging 模块的使用代码，由 Tagging 模块的设计文档去带上就好
There was a problem hiding this comment.
好的，那我先删掉了，把接口文档再根据丘吉那边的新定义改一下
|
你不要 merge 或者 rebase goplus/dev 分支啊，你们的 base 分支是 goplus/trailhead_guidance，要同步也就同步 goplus/trailhead_guidance 就好 |
neverbiasu
force-pushed
the
guidance_submodule
branch
from
273558d to
83e0cf8
Compare
我做错了寒星老师😭，我已经重新提交 |
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
No description provided.