Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-editor): support source location navigation for panic messages #1225

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

aofei
Copy link
Member

@aofei aofei commented Jan 10, 2025

Fixes #1096

Copy link

qiniu-prow bot commented Jan 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aofei aofei force-pushed the panic-source branch 3 times, most recently from 977112b to 8a966c1 Compare February 14, 2025 06:21
@aofei aofei requested a review from Copilot February 14, 2025 06:22
@aofei aofei marked this pull request as ready for review February 14, 2025 06:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • tools/ispx/go.mod: Language not supported
  • tools/spxls/go.mod: Language not supported
Comments suppressed due to low confidence (1)

spx-gui/src/components/editor/preview/InPlaceRunner.vue:94

  • The concatenation of error messages might lead to unclear or misleading error messages. Ensure that the final message is clear and informative.
lastPanicOutput.value.message = message

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • tools/ispx/go.mod: Language not supported
  • tools/spxls/go.mod: Language not supported
Comments suppressed due to low confidence (1)

spx-gui/src/components/editor/preview/InPlaceRunner.vue:89

  • The regular expression might be too specific and not cover all possible panic messages. Consider making it more flexible to cover a wider range of panic messages.
/^panic: .+ \[recovered\]$/
tools/ispx/go.mod Show resolved Hide resolved
spx-gui/src/components/editor/panels/ConsolePanel.vue Outdated Show resolved Hide resolved
tools/ispx/main.go Show resolved Hide resolved
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit 8ca78b1 into goplus:dev Feb 18, 2025
7 checks passed
@aofei aofei deleted the panic-source branch February 18, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support source location for runtime println & panic
3 participants