-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code-editor): support source location navigation for panic messages #1225
Conversation
Skipping CI for Draft Pull Request. |
977112b
to
8a966c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tools/ispx/go.mod: Language not supported
- tools/spxls/go.mod: Language not supported
Comments suppressed due to low confidence (1)
spx-gui/src/components/editor/preview/InPlaceRunner.vue:94
- The concatenation of error messages might lead to unclear or misleading error messages. Ensure that the final message is clear and informative.
lastPanicOutput.value.message = message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tools/ispx/go.mod: Language not supported
- tools/spxls/go.mod: Language not supported
Comments suppressed due to low confidence (1)
spx-gui/src/components/editor/preview/InPlaceRunner.vue:89
- The regular expression might be too specific and not cover all possible panic messages. Consider making it more flexible to cover a wider range of panic messages.
/^panic: .+ \[recovered\]$/
Fixes goplus#1096 Signed-off-by: Aofei Sheng <[email protected]>
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
Fixes #1096