Kadai2 sminamot #30
Open
Kadai2 sminamot #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knsh14
reviewed
Nov 21, 2018
| return (e == "jpg" || e == "png" || e == "gif") | ||
| } | ||
|
|
||
| func filename(f, src, dst string) string { |
There was a problem hiding this comment.
この関数名で拡張子を変更されると戸惑うのでもう少し別の名前をつけてやってください
内部実装を見れば何をしているかはわかりますが、 filename という関数名だけを見ると foo/bar.png を渡すと拡張子を除いた文字列が返ってくるようなものというイメージを受けます。
knsh14
reviewed
Nov 21, 2018
| } | ||
|
|
||
| func TestNew(t *testing.T) { | ||
| tests := []testNewStruct{ |
There was a problem hiding this comment.
ここだけ struct の型を定義をしたのはなぜでしょう？
他のテストと共通化するぞ！という使い方をしないとあまりメリットがなさそうな感じです。
There was a problem hiding this comment.
あと testNewStruct という名前がちょっと変...
僕が名前つけると testcase とかになると思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.Readerとio.Writerについて調べてみよう
1回目の宿題のテストを作ってみて下さい