Skip to content

Commit

Permalink
feat: fix helm chart configmap value & template
Browse files Browse the repository at this point in the history
Signed-off-by: Zufar Dhiyaullhaq <[email protected]>
  • Loading branch information
zufardhiyaulhaq committed Sep 28, 2024
1 parent dede5e2 commit d05fc20
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ helm install my-istio-upgrade-consumer istio-upgrade-consumer/istio-upgrade-cons
| configuration.timeLocation | string | `"Asia/Jakarta"` | |
| deployment.image | string | `"ghcr.io/gopaytech/istio-upgrade-consumer"` | |
| deployment.replicas | int | `2` | |
| deployment.tag | string | `"nightly"` | |
| deployment.tag | string | `"master"` | |
| podLabels | object | `{}` | |
| resources.limits.cpu | string | `"1024m"` | |
| resources.limits.memory | string | `"1024Mi"` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-upgrade-consumer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ helm install my-istio-upgrade-consumer istio-upgrade-consumer/istio-upgrade-cons
| configuration.timeLocation | string | `"Asia/Jakarta"` | |
| deployment.image | string | `"ghcr.io/gopaytech/istio-upgrade-consumer"` | |
| deployment.replicas | int | `2` | |
| deployment.tag | string | `"nightly"` | |
| deployment.tag | string | `"master"` | |
| podLabels | object | `{}` | |
| resources.limits.cpu | string | `"1024m"` | |
| resources.limits.memory | string | `"1024Mi"` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-upgrade-consumer/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
data:
CLUSTER_NAME: "{{ .Values.configuration.clusterName }}"
CLUSTER_ENVIRONMENT: "{{ .Values.configuration.clusterEnvironment }}"
RECEIVER_MODE: "{{ .Values.configuration.receiverMode }} "
RECEIVER_MODE: "{{ .Values.configuration.receiverMode }}"
RECEIVER_HTTP_PORT: "{{ .Values.configuration.receiverHTTPPort }}"
STORAGE_MODE: "{{ .Values.configuration.storageMode }}"
STORAGE_CONFIGMAP_NAME: "{{ .Values.configuration.storageConfigMapName }}"
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-upgrade-consumer/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
deployment:
image: "ghcr.io/gopaytech/istio-upgrade-consumer"
tag: "nightly"
tag: "master"
replicas: 2

resources:
Expand Down
6 changes: 3 additions & 3 deletions charts/releases/index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ entries:
istio-upgrade-consumer:
- apiVersion: v2
appVersion: 1.0.0
created: "2024-09-28T23:12:23.109308+07:00"
created: "2024-09-28T23:18:35.096313+07:00"
description: Consumer for Istio Upgrade tooling to receive events related to Istio
upgrade
digest: d2757ad6309f3f16f9ef430d52b3a9b22f02323bb9458913bc131848102af33f
digest: 8ebc4f8462c2c245b11a1c4e6f301516a359ee8434e056ae04bfa6ccad9232f3
home: https://github.com/gopaytech/istio-upgrade-consumer
maintainers:
- email: [email protected]
Expand All @@ -17,4 +17,4 @@ entries:
urls:
- istio-upgrade-consumer-1.0.0.tgz
version: 1.0.0
generated: "2024-09-28T23:12:23.108851+07:00"
generated: "2024-09-28T23:18:35.095931+07:00"
Binary file modified charts/releases/istio-upgrade-consumer-1.0.0.tgz
Binary file not shown.
2 changes: 1 addition & 1 deletion services/receiver/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ func UpgradeFactory(settings settings.Settings, upgradeStorage storage.UpgradeIn
return http.NewUpgradeHTTP(settings, upgradeStorage, upgradeImplementation), nil
}

return nil, fmt.Errorf("receiver is not supported")
return nil, fmt.Errorf("receiver is not supported: %s", settings.ReceiverMode)
}
2 changes: 1 addition & 1 deletion services/storage/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ func UpgradeFactory(settings settings.Settings) (UpgradeInterface, error) {
return configmap.NewUpgradeConfigMap(kubernetesConfig, settings), nil
}

return nil, fmt.Errorf("receiver is not supported")
return nil, fmt.Errorf("storage is not supported %s", settings.StorageMode)
}

0 comments on commit d05fc20

Please sign in to comment.