Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor menu key navigation problems #2062

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giovanniTramonto
Copy link
Contributor

@giovanniTramonto giovanniTramonto commented Feb 28, 2025

Fixes #2061 (problem 1)

@justvanrossum MR is not finished.

@giovanniTramonto giovanniTramonto changed the title Fix minor menu key navigation problems #2061 Fix minor menu key navigation problems Feb 28, 2025
@justvanrossum
Copy link
Collaborator

Thanks!

As a FYI: we temporarily stop merging front end PRs because there is a huge change incoming that will move many files: #2053

This big PR should get merged very soon, but your PR may have to be manually rebased for the new file location. We will help with that if needed.

Thanks for your understanding.

@justvanrossum
Copy link
Collaborator

(Feel free to convert to a draft PR to signal WIP)

@giovanniTramonto giovanniTramonto marked this pull request as draft February 28, 2025 15:12
@justvanrossum
Copy link
Collaborator

The Big Bang js-split PR has been merged. Let me know if you need help reworking this PR for the new file locations.

Pro tip: we now use a bundler, and you'll have to do pip install -e . before you can continue, and you should use the --dev option in the fontra invocation to make the bundler do an instantaneous rebuild when you make front end changes:

fontra --dev filesystem path/to/folder/with/fonts

Alternatively, you can run npm run bundle-watch in a separate terminal window.

@justvanrossum
Copy link
Collaborator

So, the file that you've edited now lives here:

Apart from the imports, nothing should have changed.

@giovanniTramonto
Copy link
Contributor Author

OK Great. Thanks for the update. Everything works on my side.

@giovanniTramonto giovanniTramonto force-pushed the fix/#2061-minor-menu-key-navigation-problems branch from 1e0ec0a to a1f9a23 Compare March 3, 2025 22:10
@giovanniTramonto
Copy link
Contributor Author

Successfully rebased and updated : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[menu, menu bar, context menu] Three minor key navigation problems with submenus
2 participants