Small bug fixes for text entry panel #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owser window Would previously overflow the bottom of the container and make the alignment buttons inaccessible.
This would cause "disappearing slashes" before, not good.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two small UI bugs were really bothering me so I fixed them.
/slash->/-> nothing (or invalid character) (triggered by modification to the glyph lines such as bycmd+left/right)Video demonstrating the bugs:
text-entry-panel-bugs.mp4
These are very trivial fixes, since I wanted to start off by contributing something small- but there are various improvements that would be desirable for the text panel, such as the ability to toggle whether to represent certain classes of glyphs as their character or
/name, for example this is kind of annoying when working with combining glyphs since you may typeA/acutecomband have it turned in toÁ, making it not possible to hand edit e.g. which base character it's applied on top of via the text panel (you can right click -> replace glyph on canvas, but that's not at all ergonomic).