Edit font infos metadata #2039
Draft
Edit font infos metadata #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here a short demo: Fontra-CustomData.mp4 |
| source.customData = {}; | ||
| for (const item of event.newValue) { | ||
| const value = parseFloat(item["value"]); | ||
| // TODO: How do we handle different types of values? |
There was a problem hiding this comment.
Maybe we can allow items to carry their own formatters, then the item would be able override the column-level formatter:
diff --git a/src/fontra/client/web-components/ui-list.js b/src/fontra/client/web-components/ui-list.js
index 614540b94..abc61bdac 100644
--- a/src/fontra/client/web-components/ui-list.js
+++ b/src/fontra/client/web-components/ui-list.js
@@ -273,7 +273,8 @@ export class UIList extends UnlitElement {
[colDesc.cellFactory(item, colDesc)]
);
} else {
- const formatter = colDesc.formatter || DefaultFormatter;
+ const formatter =
+ item.formatters?.[colDesc.key] || colDesc.formatter || DefaultFormatter;
cell = html.div(
{ class: `text-cell ${colDesc.key} ${colDesc.align || "left"}` },(Maybe the key shouldn't be "formatter", but we can decide later.)
This reverts commit 98df6fb.
…ute which has no UFO mapping
…don't add placeholder "attributeName"
This is for discussion.
…omDataNameMapping
ollimeier
force-pushed
the
issue-2023-edit-font-infos-metadata
branch
from
a13f394 to
f27e558
Compare
…b.com/googlefonts/fontra into issue-2023-edit-font-infos-metadata-2
…metadata-2 Edit font infos metadata 2
…custom data dialog
|
@justvanrossum About the label of customData, currently 'Advanced Information': What do you think about 'Low-level settings'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2023
This is an early draft for feedback.
My main question: Is it the right direction to add and use a Fontra to UFO mapping for customData parameters (it's similar to
lineMetricsVerMapping)?I am also wondering if
fontInfoNameMappingshould be a dict instead of a list? But this is not related to this issue. I am just noticing it and wondering if we should make it consistent?