Add reference-font remove button

[giovanniTramonto]

Before reference-font items could only be deleted by selecting (clicking) an item and pressing delete-key after. Not self-explanatory.
Now there is a remove (-) button at the end of each line.

[justvanrossum]

We use at least two different things for this in Fontra:

• (+) (-) buttons below the list (for example in glyph source list)
• a "trash" icon at the right end side of a panel/row/thing

In the context of lists, so far we only use the (+) (-) approach. So that would be more consistent with other parts of Fontra. (The "+" button could trigger a file upload dialog)

On the other hand, to have a delete icon ("trash" would be preferred then), is a bit more user friendly, as it doesn't require an item to be selected first.

I don't think this icon needs to be so deeply integrated into the ui-list class. Look at for example the glyph source list: it contains clickable icons.

I'm leaning towards to (+) (-) solution.

[giovanniTramonto]

Ah yes, I see, that’s much easier, actually. Thanks for the hint

[giovanniTramonto]

I reversed changes in ui-list.js
So after staching commits there wont be changes in ui-list.

[ollimeier]

Hi @giovanniTramonto (Johannes), thanks a lot that you help us with Fontra. I much appreciate that and it's great to be in contact with you this way, again.
I tested it and it works well. Please see my comments.

[giovanniTramonto]

Hi @ollimeier!
Thanks for the review. Yes, indeed, great to work with you guys on this. Appreciate it very much, too.
I have implemented all suggestions as well as some improvement on the selection: Now, it automatically selects last row after removal, so it’s easier to remove multiple items as well.
I spot that the supported languages do not update when the list becomes empty. If it’s OK with you I would adjust this in a follow-up.

[ollimeier]

Thanks a lot for your update. Seems to work well. I have only a few minor change requests related to the text strings in the dialog.
I noticed that the reference font is not displayed if we add only one font. Here a quick demo:

Screen.Recording.2025-02-13.at.09.06.43.mp4

This was not introduced by you. It was there already before. We may want to have a look into that issue as a follow up.

[giovanniTramonto]

Thanks a lot for your update. Seems to work well. I have only a few minor change requests related to the text strings in the dialog. I noticed that the reference font is not displayed if we add only one font. Here a quick demo:

Screen.Recording.2025-02-13.at.09.06.43.mp4
This was not introduced by you. It was there already before. We may want to have a look into that issue as a follow up.

Oh, interesting! Just tried to reproduce. For me it seems to work:

reference-font.mov

[justvanrossum]

Is it possible for the "+" button to immediately do to the choose files dialog, without the in-between dialog?

[giovanniTramonto]

Oh, yes. This is much more practical

[ollimeier]

@justvanrossum @giovanniTramonto This last change is so much better. Keep it simple, right!
I tested it and it works well. I am going to give it an approval, but I will not merge it. So, that you Just have the chance to look at it.

[justvanrossum]

I left one comment, otherwise looks good to me.

I think this review has been resolved, I'm not sure why it isn't marked as such.

[justvanrossum]

Thanks.

Should the remove button perhaps also respond to the alt key, to mean "delete all"?

So currently no item gets selected after removing the selection, right? This matches the original behavior, but not wat we recently discussed. Is that your intention indeed?

[giovanniTramonto]

Thanks.

Should the remove button perhaps also respond to the alt key, to mean "delete all"?

So currently no item gets selected after removing the selection, right? This matches the original behavior, but not wat we recently discussed. Is that your intention indeed?

Now, it selects the item before in the list, or after in case its the first list item. Feels good

[giovanniTramonto]

For the deleting multiple files, I guess, really nice would be to select a range with shift key.

But I have to solve this render glitch before:

glitch.mov

[justvanrossum]

For the deleting multiple files, I guess, really nice would be to select a range with shift key.

Yes, but the UIList class currently does not support that. While we need that eventually, it is out of scope for this PR.

But I have to solve this render glitch before:

Is it related to the file names being wrapped?

[justvanrossum]

I'm willing to merge this as it is: it works well and the code looks fine to me. What do you say?

[giovanniTramonto]

Glitch is fixed. It was related to the render update of ui-list which caused update of parent grid. Moving the list inside a wrapper helped. I also set keepScrollPosition to true, so when having many items after removal user can still see the selected item without scrolling down again. If that’s all fine with you, I’m willing to merge, too.

[justvanrossum]

But now the layout behavior is different: the preview section at the bottom takes up more space than it needs when the size is small, leaving a lot of space unused:

[giovanniTramonto]

OK, I reset the layout changes and only set the keep-scroll-position, which I guess is useful when deleting items. I compared with main which has the glitch, too. So this MR does not cause it and I can look at this in a follow-up. Feel free to merge.