fix: Use include rather than exclude to find_namespace_packages in setup.py #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html has a warning: > Please have in mind that find_namespace: (setup.cfg), > find_namespace_packages() (setup.py) and find (pyproject.toml) > will scan all folders that you have in your project directory > if you use a flat-layout. That applies here. Without this change, if you run: 'python3 setup.py bdist_wheel' then you may end up with build/ in your wheel, and in some cases even docs/ and testing/ . The fix is to only include proto and proto.*. Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
fix/no-build-in-wheel
branch
from
1302ce3 to
cb06758
Compare
|
After a lot more testing and debugging I have a better idea of what is going on. I now think this is right, and is in-line with what is happening in other googleapis projects like https://github.com/googleapis/python-aiplatform/blob/f1da73b10d94d55a76d29de23fc3e198a37f78b6/setup.py#L36 and https://github.com/googleapis/python-pubsub/blob/5c78ac961199cd094ac4d29634fa4b6bfb73436a/setup.py#L62 . Its better to be explicit and have to extend this list if there is ever a need. I can modify the PR to be more like one of those if requested. |
parthea
changed the title
parthea
approved these changes
Jan 22, 2025
|
Thanks @smoser! |
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added a commit
that referenced
this pull request
Jan 22, 2025
* migrate to pyproject.toml * Rebase following #502 * add entries such as documentation and classifiers which exist in other projects * Use correct url for docs --------- Co-authored-by: Anthonios Partheniou <[email protected]>
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html has a warning:
That applies here. Without this change, if you run: 'python3 setup.py bdist_wheel' then you may end up with build/ in your wheel, and in some cases even
docs/ and testing/ .
The fix is to only include proto and proto.*.
Fixes #503