feat: add Lineage metrics for CloudBigtableIO #4438
Draft
+72
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
ad548
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: m
ad548
force-pushed
the
adas-lineage
branch
2 times, most recently
from
24012e1 to
ce85893
Compare
ad548
force-pushed
the
adas-lineage
branch
13 times, most recently
from
8d18829 to
0719214
Compare
ad548
commented
Nov 5, 2024
| @@ -142,8 +147,11 @@ public void testWriteToBigtable() throws IOException { | |||
| DataflowPipelineOptions options = PipelineOptionsFactory.as(DataflowPipelineOptions.class); | |||
| properties.applyTo(options); | |||
| options.setAppName("testWriteToBigtable-" + System.currentTimeMillis()); | |||
| options.setExperiments(Collections.singletonList("disable_runner_v2")); | |||
There was a problem hiding this comment.
runner v2 (which is used by default) doesn't have the support for retrieving lineage metrics yet.
There was a problem hiding this comment.
We'll wait for the support to be added before moving forward with these changes. Confirmed that changes work fine otherwise.
ad548
force-pushed
the
adas-lineage
branch
4 times, most recently
from
ebc53bc to
864e1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.