Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated calls to proto oneof builders #4360

Open
wants to merge 1 commit into
base: bigtable-1.x
Choose a base branch
from

Conversation

cushon
Copy link

@cushon cushon commented May 16, 2024

This change removes duplicated calls to proto oneof builders where a previously set value is overwritten in the fluent chain.

Fixes #4359 ☕️

where a previously set value is overwritten in the fluent chain.

googleapis#4359
@cushon cushon requested a review from a team as a code owner May 16, 2024 15:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels May 16, 2024
@cushon cushon changed the title fix: Remove duplicated calls to proto oneof builders fix: remove duplicated calls to proto oneof builders May 16, 2024
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 22, 2024
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants