fix: don't re-add metrics to x-goog-api-client header

googleapis · Jun 21, 2024 · 29c7b97 · 29c7b97
1 parent cb98227
commit 29c7b97
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/google/auth/metrics.py b/google/auth/metrics.py
@@ -150,5 +150,5 @@ def add_metric_header(headers, metric_header_value):
         return
     if API_CLIENT_HEADER not in headers:
         headers[API_CLIENT_HEADER] = metric_header_value
-    else:
+    elif metric_header_value not in headers[API_CLIENT_HEADER]:
         headers[API_CLIENT_HEADER] += " " + metric_header_value
diff --git a/tests/test_metrics.py b/tests/test_metrics.py
@@ -29,6 +29,10 @@ def test_add_metric_header():
     metrics.add_metric_header(headers, "bar")
     assert headers == {"x-goog-api-client": "foo bar"}
 
+    headers = {"x-goog-api-client": "foo"}
+    metrics.add_metric_header(headers, "foo")
+    assert headers == {"x-goog-api-client": "foo"}
+
     headers = {}
     metrics.add_metric_header(headers, "bar")
     assert headers == {"x-goog-api-client": "bar"}